RBT-928 pass through jakarta annotations #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dc120e4.
…ry-2 # Conflicts: # graphql-builder/src/main/java/com/phocassoftware/graphql/builder/DirectivesSchema.java # graphql-builder/src/main/java/com/phocassoftware/graphql/builder/MethodProcessor.java # graphql-builder/src/test/java/com/phocassoftware/graphql/builder/JakartaValidationDirectiveTest.java # graphql-builder/src/test/java/com/phocassoftware/graphql/builder/type/directive/Cat.java # pom.xml
josie-atkins
changed the title
…ry-2 # Conflicts: # graphql-builder/pom.xml # graphql-builder/src/test/java/com/phocassoftware/graphql/builder/DirectiveTest.java
…h-jakarta-annotations-try-2 # Conflicts: # graphql-builder/pom.xml
ashley-taylor
requested changes
Jun 8, 2025
| <junit.jupiter.version>5.12.2</junit.jupiter.version> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <jackson.version>2.19.0</jackson.version> | ||
| <graphql.version>22.0</graphql.version> |
There was a problem hiding this comment.
version gone done to 22 from 24
There was a problem hiding this comment.
Yes, unfortunately the graphql-java-extended-validation library has not released support for graphql 24 yet.
There was a problem hiding this comment.
Their readme says "use 22.0 or above for graphql-java 22.x and above"
There was a problem hiding this comment.
This is the issue I am running into: graphql-java/graphql-java-extended-validation#103
There was a problem hiding this comment.
May have to be an open source developer and submit a PR up stream to add support for graphql 24
There was a problem hiding this comment.
I guess now we wait graphql-java/graphql-java-extended-validation#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopes to add Jakarta validation to the graphql builder library.
.validate()flag is called on the schema builder.