Fix pending link update race condition#3710
Merged
chrismccord merged 1 commit intomainfrom Mar 7, 2025
Merged
Conversation
applyPendingDiffs had a race condition where updates were silently dropped if when trying to apply them there was already a new pending link. We fix this by skipping applyPendingDiffs when a link is still pending. Bug originally reported by @Gazler: https://gist.github.com/Gazler/80dac42d3134ff55219853f1cb105e78
Member
|
❤️❤️❤️🐥🔥 |
SteffenDE
added a commit
that referenced
this pull request
Mar 10, 2025
applyPendingDiffs had a race condition where updates were silently dropped if when trying to apply them there was already a new pending link. We fix this by skipping applyPendingDiffs when a link is still pending. Bug originally reported by @Gazler: https://gist.github.com/Gazler/80dac42d3134ff55219853f1cb105e78
SteffenDE
added a commit
that referenced
this pull request
Aug 19, 2025
SteffenDE
added a commit
that referenced
this pull request
Aug 20, 2025
SteffenDE
added a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyPendingDiffs had a race condition where updates were silently dropped if when trying to apply them there was already a new pending link. We fix this by skipping applyPendingDiffs when a link is still pending.
Fixes #3709.
Bug originally reported by @Gazler:
https://gist.github.com/Gazler/80dac42d3134ff55219853f1cb105e78