Skip to content

Fix in url parser after go 1.12.8 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Conversation

wayjam
Copy link
Contributor

@wayjam wayjam commented Nov 6, 2019

Description

Fix net/url.Parse no longer works for dsn string with port after go 1.12.8

parse mysql://user@tcp(localhost:3306)/boulder_test?parseTime=true: invalid port ":3306)" after host

Releated issue: golang/go#33646

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README.md / documentation, if necessary
  • Added myself / the copyright holder to the CONTRIBUTORS file

@wayjam
Copy link
Contributor Author

wayjam commented Nov 13, 2019

@phogo-bot @Svett

@iamralch iamralch added the bug Something isn't working label Nov 13, 2019
@iamralch
Copy link
Contributor

iamralch commented Nov 13, 2019

@wayjam Thanks for the PR. I will review it soon. It looks like that my github notification settings were not correct. So I didn't see the PR earlier. Sorry about that.

Copy link
Contributor

@iamralch iamralch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the cases that I have concerns.

Copy link
Contributor

@iamralch iamralch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution! I will schedule release by the end of this week.

@iamralch iamralch merged commit 15f1997 into phogolabs:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants