ArrayAccess should be explicitly implemented

[rtheunissen]

This is so that it's possible to call the array access functions directly, even though no one should ever need to do that.

• Test calling the offset* functions as well.

[rtheunissen]

Added within 0181344

[castarco]

It seems that the implementation of this interface on Vector is not documented on the official PHP site ( https://secure.php.net/manual/en/book.ds.php )

[andrew-demb]

Hello @rtheunissen.

Added within 0181344

I can't find the mentioned commit and these changes in any branch and any mention in changelogs about removing this functionality from the extension.

Is it planned to remove implementing \ArrayAccess?
I can create new issue here, or we can drop implementation of \ArrayAccess in polyfill to not confuse users?
php-ds/polyfill#47

[rtheunissen]

You mean this commit? 0181344

We are not removing ArrayAccess, I'm sorry but what are you suggesting exactly? Looking at this again it seems like we're not implementing ArrayAccess properly.

[andrew-demb]

Yes, this commit.

I'm suggested to remove implementing ArrayAccess from polyfill, if extension won't provide implementation.

Or open issue here instead :)

Thank you.

[ManuelHirsch]

FYI - I just tripped over this when developing with the polyfill but having the extension on the test system (fortunately not live!).

For google, to relate this issue with the error message: "Fatal error: Uncaught Error: Call to undefined method Ds\Vector::getIterator() in ..." and probably all ArrayAccess methods then.

[dktapps]

This also causes some issues with static analysers (f.e. phpstan/phpstan#2847)

[rtheunissen]

Done and released as part of 1.3.0