[client] DelayRedeliveredMessageExtension should do nothing if status already set

fixes #36

Author: makasim

Diff for: pkg/enqueue/Client/ConsumptionExtension/DelayRedeliveredMessageExtension.php

@@ -45,6 +45,9 @@ public function onPreReceived(Context $context)
         if (false == $message->isRedelivered()) {
             return;
         }
+        if (false != $context->getResult()) {
+            return;
+        }
 
         $delayedMessage = $this->driver->createClientMessage($message);
 

Diff for: pkg/enqueue/Consumption/ExtensionInterface.php

@@ -24,17 +24,17 @@ public function onBeforeReceive(Context $context);
     /**
      * Executed when a new message is received from a broker but before it was passed to processor
      * The context contains a message.
-     * The extension may set a status.
-     * The consumption could be interrupted at this step but it will done only after the message is processed.
+     * The extension may set a status. If the status is set the exception is thrown
+     * The consumption could be interrupted at this step but it exits after the message is processed.
      *
      * @param Context $context
      */
     public function onPreReceived(Context $context);
 
     /**
      * Executed when a message is processed by a processor.
-     * The context contains a message status and could be changed
-     * The consumption could be interrupted at this step but it will done only after the message is processed.
+     * The context contains a status, which could not be changed.
+     * The consumption could be interrupted at this step but it exits after the message is processed.
      *
      * @param Context $context
      */

Diff for: pkg/enqueue/Tests/Client/ConsumptionExtension/DelayRedeliveredMessageExtensionTest.php

@@ -97,6 +97,25 @@ public function testShouldDoNothingIfMessageIsNotRedelivered()
         self::assertNull($context->getResult());
     }
 
+    public function testShouldDoNothingIfMessageIsRedeliveredButResultWasAlreadySetOnContext()
+    {
+        $message = new NullMessage();
+        $message->setRedelivered(true);
+
+        $driver = $this->createDriverMock();
+        $driver
+            ->expects(self::never())
+            ->method('sendToProcessor')
+        ;
+
+        $context = new Context($this->createPsrContextMock());
+        $context->setPsrMessage($message);
+        $context->setResult('aStatus');
+
+        $extension = new DelayRedeliveredMessageExtension($driver, 12345);
+        $extension->onPreReceived($context);
+    }
+
     /**
      * @return \PHPUnit_Framework_MockObject_MockObject|DriverInterface
      */