Skip to content

CreateTopic is called #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hpatoio opened this issue Feb 12, 2020 · 5 comments
Closed

CreateTopic is called #1022

hpatoio opened this issue Feb 12, 2020 · 5 comments
Labels

Comments

@hpatoio
Copy link

hpatoio commented Feb 12, 2020

I've just installed and configured enqueue. Why is CreateTopic called ? I already created the SNS topic but enqueue call it anyway.

@Steveb-p
Copy link
Contributor

CreateTopic does not actually create topic on broker, but instead it creates an object responsible for working with a topic / queue.

At least that's my assumption, since I'm not familiar with SNS/SQS - but almost every enqueue package behaves this way.

Unless it enqueue actually tries to create a topic on a broker and causes you an issue, I'm closing this.

@tyloo
Copy link

tyloo commented Feb 19, 2020

@Steveb-p : It actually does a createTopic query to the broker. Problem is, we have set our IAM credentials to not have the right to create a topic.

AuthorizationError (client): User: arn:aws:sts::... is not authorized to perform: SNS:CreateTopic on resource: arn:aws:sns:eu-west-1:...:dev-messenger

@jderusse
Copy link

Actually, SNS component creates a topic in order to fetch the ARN:

https://github.com/php-enqueue/sns/blob/0568fa5168b39a48362a46db5638a5d0f586632f/SnsContext.php#L66-L77

which is called in
https://github.com/php-enqueue/sns/blob/0568fa5168b39a48362a46db5638a5d0f586632f/SnsContext.php#L144-L151

Please reopen the issue.

@timgregg
Copy link

timgregg commented Feb 16, 2021

@Steveb-p It does create an sns topic is it possible to reopen this issue?

@Steveb-p Steveb-p reopened this Feb 16, 2021
paramonov pushed a commit to paramonov/enqueue-dev that referenced this issue Mar 18, 2021
makasim added a commit that referenced this issue Mar 18, 2021
[sns] added possibility to define already existing topics (prevent create topic call) #1022
@makasim
Copy link
Member

makasim commented Mar 18, 2021

fixed in #1147

@makasim makasim closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants