Skip to content

[Redis] Messages sent with incorrect delivery delay #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niels-nijens opened this issue Jan 22, 2019 · 1 comment
Closed

[Redis] Messages sent with incorrect delivery delay #737

niels-nijens opened this issue Jan 22, 2019 · 1 comment
Labels

Comments

@niels-nijens
Copy link
Contributor

When sending a message with a delay (in seconds) to the Redis transport the following happens:

  1. The delay is provided in seconds. For example 5 seconds.
  2. The deliveryDelay is set on a new RedisProducer by the RedisDriver in milliseconds based on the delay of the message.
  3. The deliveryDelay (in milliseconds) is added to time() (in seconds). Resulting in a delay of 83 minutes and 20 seconds instead of 5 seconds. See the RedisProducer.

Step 3 should divide the deliveryDelay milliseconds back to seconds before adding it to time().

If you'd like, I can provide a PR with the necessary change(s).

@makasim
Copy link
Member

makasim commented Jan 22, 2019

It would be great if you could provide a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants