feat(snsqs): allow client http configuration for sns and sqs #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eortiz-tracktik
force-pushed
the
issue-1213
branch
from
ef63d3c to
2555ac1
Compare
|
@makasim I'm sorry about the tests not passing, will enable the workflow in the fork and fix this. Also, looks like you updated the |
eortiz-tracktik
force-pushed
the
issue-1213
branch
4 times, most recently
from
7ad076d to
e68b12e
Compare
This changes allow to set in the AWS Sdk client the http configurations: https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#config-http This will make possible to define custom `connect_timeout` and `timeout` to fail fast when the network is not relaible. Reported on php-enqueue#1213
eortiz-tracktik
force-pushed
the
issue-1213
branch
from
e68b12e to
45b74c9
Compare
|
Hello @makasim. |
|
@makasim any idea when we will have a new release with the latest changes merged in master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes allow to set in the AWS Sdk client the http configurations:
https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#config-http
This will make possible to define custom
connect_timeoutandtimeoutto fail fast when the network is not relaible.Reported on #1213