Skip to content

Fix AWS SDK token parameter #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix AWS SDK token parameter #1284

merged 2 commits into from
Feb 10, 2023

Conversation

andrewmy
Copy link
Contributor

@andrewmy andrewmy commented Feb 8, 2023 •
edited
Loading

It looks like in recent versions the AWS SDK started enforcing parameter types, breaking our CI.

InvalidArgumentException: Invalid configuration value provided for "token". Expected Aws\Token\TokenInterface|Aws\CacheInterface|array|bool|callable, but got string(0) ""

When passing false, it still breaks:

InvalidArgumentException: Token must be an instance of Aws\Token\TokenInterface, an associative array that contains "token" and an optional "expires" key-value pairs, a token provider function, or false.

So let's just skip it in tests.

@andrewmy andrewmy marked this pull request as ready for review February 8, 2023 14:10
@andrewmy andrewmy mentioned this pull request Feb 8, 2023
Merged
@andrewmy
Copy link
Contributor Author

@makasim could you please review? Thanks!

@makasim makasim merged commit a2b6082 into php-enqueue:master Feb 10, 2023
@makasim
Copy link
Member

makasim commented Feb 10, 2023

@andrewmy thanks

@andrewmy andrewmy deleted the fix-aws-sdk-token branch February 10, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewmy @makasim