Add AmqpLib support #136
Add AmqpLib support #136
Conversation
composer.json
Outdated
| @@ -7,6 +7,7 @@ | |||
| "enqueue/enqueue": "*@dev", | |||
| "enqueue/stomp": "*@dev", | |||
| "enqueue/amqp-ext": "*@dev", | |||
| "enqueue/amqplib": "*@dev", | |||
There was a problem hiding this comment.
Could you please rename it to amqp-lib? Same goes for the composer package name
| private $config; | ||
| private $connection; | ||
|
|
||
| public function __construct(array $config = []) |
There was a problem hiding this comment.
can you please add doc blocks for the properties and methods
pkg/amqplib/AmqpConsumer.php
Outdated
| class AmqpConsumer implements PsrConsumer | ||
| { | ||
| private $channel; | ||
| private $queue; |
There was a problem hiding this comment.
we use php-cs-fixer to make sure the code looks similar. Could you please use it too? https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md
pkg/amqplib/AmqpConsumer.php
Outdated
|
|
||
| public function receive($timeout = 0) | ||
| { | ||
| $end = microtime(true) + ($timeout / 1000); |
There was a problem hiding this comment.
it would be good to add a basic_consume support. But it could be done at a later stage.
| @@ -0,0 +1,49 @@ | |||
| <?php | |||
|
|
|||
| namespace Enqueue\Amqplib; | |||
There was a problem hiding this comment.
Could you please change it to Enqueue\AmqpLib?
|
@fibula It would be also great if you could add some tests. You can use https://github.com/queue-interop/queue-spec |
pkg/amqp-lib/AmqpConsumer.php
Outdated
| { | ||
| $end = microtime(true) + ($timeout / 1000); | ||
|
|
||
| while (0 === $timeout || microtime(true) < $end) { |
There was a problem hiding this comment.
would be able to add a support of basic_consume. You can look how we did it in amqp ext transport
There was a problem hiding this comment.
ok, I will give a try
fixes #128