Fixed losing message priority for dbal driver #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM in general though there is issue with code style https://travis-ci.org/php-enqueue/enqueue-dev/jobs/274379202 |
|
@vtsykun could you please add this spec test https://github.com/queue-interop/queue-spec/blob/master/src/SendAndReceivePriorityMessagesFromQueueSpec.php You can find out how to do it in other transport which use spec tests. For example amqp ext. |
makasim
reviewed
Sep 13, 2017
| @@ -176,7 +176,7 @@ protected function receiveMessage() | |||
| ->where('queue = :queue') | |||
| ->andWhere('(delayed_until IS NULL OR delayed_until <= :delayedUntil)') | |||
| ->orderBy('priority', 'desc') | |||
| ->orderBy('id', 'asc') | |||
| ->addOrderBy('id', 'asc') | |||
There was a problem hiding this comment.
it should be desc. gonna fix it
There was a problem hiding this comment.
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
Fixed losing message priority for dbal driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.