-
Notifications
You must be signed in to change notification settings - Fork 440
Adds to small extension points to JobProcessor #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@iainmckay Could you shade some light on how this extension point is supposed to be used? |
Sorry, yes. My team is currently in the middle of modernising an application. One aspect we are in the process of updating is how we process some of our workloads and pushing them to a background/asynchronous workflow. We're using the New functionality built for this application was designed to work in a completely async fashion and to talk with our command bus but we have many older parts of the application which, for various reasons, just don't play well and assumes all operations are executing in the same process. We override the This was the least hassle way we came up with to bridge our legacy code. I would say it is not a massive change in itself but it helps us out massively. I would expect this is very particular to our project and even for ourselves it has a limited lifespan as we're rewriting the ageing modules. |
@iainmckay Fair enough. Could you please add a link to your description in the docblocks? I am going to merge it after. |
If I've understood you correctly, I've updated the PR. Thanks for merging it. |
@iainmckay As a side note. We are working on a job manager microservice. It is almost done. https://github.com/php-comrade/comrade-dev The doc still needs polishing.If you find it interesting feel free to ask me for guidance |
Thanks. We'll keep an eye on it. We're still figuring out exactly how our job system should look as we run a single-tenant app but installed multiple times for our clients which we host so we're trying to keep all data isolated but have a shared worker environment (each worker should stand up the client's instance with their configuration, etc. to execute a job). |
Comrade does not perform jobs itself, instead, it can send a message to queue or HTTP request. So it is perfectly fine to have workers on a client side (as long as they are connected to a queue or expose HTTP API). Worth to mention that a worker could be written in any language not only PHP. |
Adds to small extension points to JobProcessor
No description provided.