Skip to content

Fix ping to check each connection, not only first one #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 589 commits into from
Closed

Fix ping to check each connection, not only first one #649

wants to merge 589 commits into from

Conversation

webmake
Copy link
Contributor

@webmake webmake commented Nov 22, 2018

No description provided.

makasim and others added 30 commits October 2, 2018 19:55
@makasim
Multiple transport support. Container based approach.
9fd20c2
@versh23
[STOMP] make getStomp public
f2d26f1
@versh23
add test
1a8e44e
@versh23
fix
3f5e9c3
@versh23
phpcs
17337e3
@makasim
Merge pull request php-enqueue#552 from versh23/stomp-public
d5984eb 
[STOMP] make getStomp public
@makasim
Make cli commands multi transport\client.
fce6c46
@makasim
Merge pull request php-enqueue#548 from php-enqueue/consumer-multiple…
389b5ce 
…-transport-support

[consumption] Add ability to consume from multiple transports.
@makasim
[consumption] Rework QueueConsumer extension points.
75095cb
@makasim
[consumption] fix onStart extension tests.
52c4cb9
@makasim
[consumption] Add preSubscribe extension point.
754cd77
@makasim
Fix tests.
490c62b
@makasim
[consumption] Add preConsume extension point, remove beforeReceive.
dd32103
@makasim
[consumption] onPreReceived -> onMessageReceived
83bd77d
@makasim
[consumption] use custom MessageResutl context on onResult.
e74b9f1
@makasim
[consumption] Introduce ProcessorException extension point. Split Ext…
5faac4f 
…ension Interface.
@makasim
[consumption] add already_ack result, queue consumer does nothing on it.
c2e5d02
@makasim
[consumption] post message received
2ec051d
@makasim
remove idle_time.
91abc46
@makasim
[consumption] onIdle -> onPostConsume
6783f04
@makasim
[consumption] Remove onInterrupted. Add onEnd. Remove context object …
c31f8b4 
…and consumption interrupted exception.
@makasim
[consumption] Implement only required extension interfaces. Remvoe Em…
7fc8cca 
…ptyExtensionTrait.
@makasim
Merge pull request php-enqueue#554 from php-enqueue/queue-consumer-ex…
98dd6b5 
…tensions

[consumption] Rework QueueConsumer extension points.
@makasim
[consumption] add InitLogger extension point. Before start.
10e05d6
@makasim
[consumption] Add LogExtension.
9ad9bc2
@makasim
[consumption][client] Add client aware log extension.
d93da58
@makasim
fix tests.
0b30496
@makasim
[simple-client] Register log extension.
fced817
@makasim
Merge pull request php-enqueue#555 from php-enqueue/loging-improvements
0362766 
[consumption] Logging improvements
@makasim
[client] Move services definition to ClientFactory.
2861bd5
makasim and others added 22 commits November 16, 2018 17:10
@makasim
Merge pull request php-enqueue#639 from php-enqueue/multi-client-conf…
9a182c1 
…iguration

Fix compiler pass
@makasim
Merge pull request php-enqueue#640 from php-enqueue/dbal-do-not-fail-…
815083c 
…on-consumption

[dbal] handle gracefully concurrency issues or 3rd party interruptions.
@makasim
[bundle] Add BC for topic\command subscribers.
b617dea
@makasim
fix tests.
53962b9
@makasim
[dbal] Use RetryableException, wrap fetchMessage exception to it too.
301522f
@makasim
Merge pull request php-enqueue#641 from php-enqueue/add-bc-topic-comm…
1739ea5 
…and-subsribers-compatibility

[bundle] Add BC for topic\command subscribers.
@makasim
Merge pull request php-enqueue#642 from php-enqueue/dbal-use-retryabl…
c8936f8 
…e-exception

[dbal] Use RetryableException, wrap fetchMessage exception to it too.
@makasim
[dsn] Cluster DSN
0d57187
@makasim
always return query bag on getArray.
728bf1c
@makasim
fix
1af223d
@makasim
Merge remote-tracking branch 'origin/master' into merge08
7f70319 
pkg/enqueue-bundle/Tests/Functional/Events/AsyncListenerTest.php
pkg/enqueue-bundle/Tests/Functional/Events/AsyncProcessorTest.php
pkg/enqueue-bundle/Tests/Functional/Events/AsyncSubscriberTest.php
@makasim
remove unrelated changes.
9c8a399
@makasim
remove unrelated changes.
79b5cf5
@makasim
Merge pull request php-enqueue#644 from php-enqueue/merge08
9e44afe 
Merge08
@makasim
Merge remote-tracking branch 'origin/master' into dsn-cluster
ec2ffbb
@makasim
fix tests.
84bd457
@makasim
Merge pull request php-enqueue#643 from php-enqueue/dsn-cluster
fa06187 
[dsn] Parse DSN Cluster
@makasim
Rework DriverFactory, add separator option to Client Config.
e7f64ae
@makasim
[client] update rabbitmq stomp driver configuration
01f00d8
@makasim
[doc] update config ref.
dab2bc4
@makasim
Merge pull request php-enqueue#646 from php-enqueue/driver-factory-re…
973ac0f 
…work

Rework DriverFactory, add separator option to Client Config.
Fix ping to check each connection, not only first one
72d4097
@makasim
Copy link
Member

makasim commented Nov 22, 2018

@webmake could you change the base branch to 0.8. It would be good to have it fixed there too.

@webmake webmake changed the base branch from master to 0.8 November 22, 2018 11:44
@webmake
Copy link
Contributor Author

webmake commented Nov 22, 2018 •
edited
Loading

Okay, I did it.

Also it seems random test failure:

1) Enqueue\Dbal\Tests\Functional\DbalConsumerTest::testShouldOrderMessagesWithSamePriorityByPublishedAtDate
InvalidArgumentException: $bytes string should contain 16 characters.
2) Enqueue\SimpleClient\Tests\Functional\SimpleClientTest::testSendEventWithTwoSubscriber with data set "dbal_dsn" (array('mysql://root:rootpass@mysql/mqdev'), '+1sec')
InvalidArgumentException: $bytes string should contain 16 characters.

not related with a change

@makasim
Copy link
Member

makasim commented Nov 22, 2018

@webmake yeap.

@makasim
Copy link
Member

makasim commented Nov 22, 2018

@webmake it added to much an related changes to the PR (because of base branch change). Would it be possible to cherry-pick your commit to a new PR with 0.8 as a base?

@webmake
Copy link
Contributor Author

webmake commented Nov 22, 2018

Yeah, i see. Okay

@webmake webmake closed this Nov 22, 2018
@webmake webmake mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.