Skip to content

[dbal] Use ordered bytes time uuid codec on message id decode. #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

makasim
Copy link
Member

@makasim makasim commented Nov 30, 2018

fixes #657

https://travis-ci.org/php-enqueue/enqueue-dev/jobs/458362777

1)
Enqueue\Dbal\Tests\Functional\DbalConsumerTest::testShouldOrderMessagesWithSamePriorityByPublishedAtDate
InvalidArgumentException: $bytes string should contain 16 characters.
/mqdev/vendor/ramsey/uuid/src/Codec/StringCodec.php:97
/mqdev/vendor/ramsey/uuid/src/UuidFactory.php:188
/mqdev/vendor/ramsey/uuid/src/Uuid.php:632
/mqdev/pkg/dbal/DbalContext.php:155
/mqdev/pkg/dbal/DbalConsumerHelperTrait.php:82
/mqdev/pkg/dbal/DbalConsumer.php:83
/mqdev/vendor/queue-interop/queue-interop/src/Impl/ConsumerPollingTrait.php:42
/mqdev/pkg/dbal/Tests/Functional/DbalConsumerTest.php:95

https://travis-ci.org/php-enqueue/enqueue-dev/jobs/458362777

```
1)
Enqueue\Dbal\Tests\Functional\DbalConsumerTest::testShouldOrderMessagesWithSamePriorityByPublishedAtDate
InvalidArgumentException: $bytes string should contain 16 characters.
/mqdev/vendor/ramsey/uuid/src/Codec/StringCodec.php:97
/mqdev/vendor/ramsey/uuid/src/UuidFactory.php:188
/mqdev/vendor/ramsey/uuid/src/Uuid.php:632
/mqdev/pkg/dbal/DbalContext.php:155
/mqdev/pkg/dbal/DbalConsumerHelperTrait.php:82
/mqdev/pkg/dbal/DbalConsumer.php:83
/mqdev/vendor/queue-interop/queue-interop/src/Impl/ConsumerPollingTrait.php:42
/mqdev/pkg/dbal/Tests/Functional/DbalConsumerTest.php:95
```
@makasim makasim changed the title [dbal] Fix ordered bytes time codec for message id on decode. [dbal] Use ordered bytes time uuid codec on message id decode. Nov 30, 2018
@makasim makasim merged commit c285f64 into master Nov 30, 2018
@makasim makasim deleted the dbal-wrong-bytes-id branch November 30, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dbal] InvalidArgumentException: $bytes string should contain 16 characters.
1 participant