[fs] Do not throw error in jsonUnserialize on deprecation notice #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by queue-interop package [ErrorException] The "Enqueue\Fs\FsMessage" class implements "Interop\Queue\PsrMessage" that is deprecated will be removed in later versions. use one without Psr prefix. * The Message interface is the root interface of all transport messages. Most message-oriented middleware (MOM) products treat messages as lightweight entities that consist of a header and a payload. The header contains fields used for message routing an d identification; the payload contains the application data being sent. * Within this general form, the definition of a message varies significantly across products. thrown here: https://github.com/ssiergl/enqueue-dev/blob/master/pkg/fs/FsConsumer.php#L131
|
@makasim as discussed ignoring the deprecation. Works as expected now |
|
well failed functional testing is not caused by this patch :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by queue-interop package
[ErrorException]
The "Enqueue\Fs\FsMessage" class implements "Interop\Queue\PsrMessage" that is deprecated will be removed in later versions. use one without Psr prefix.
d identification; the payload contains the application data being sent.
thrown here: https://github.com/ssiergl/enqueue-dev/blob/master/pkg/fs/FsConsumer.php#L131
As discussed in gitter. Without this patch fs transporter is not usable.