[dbal]: make dbal connection config usable again #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiergl
force-pushed
the
master
branch
3 times, most recently
from
e9a0e25 to
9b345b3
Compare
|
This is nice, could you please add a test for this case to DbalConnectionFactoryConfigTest? |
|
yeah right now working on a pimcore plugin and the connection variables are pretty long...so the dsn is nearly unreadable :-p added config tests. Not tested...but should be ok |
makasim
reviewed
Feb 14, 2019
ssiergl
force-pushed
the
master
branch
2 times, most recently
from
9990b73 to
82277d2
Compare
|
tested all possible configurations...looks all well |
makasim
reviewed
Feb 14, 2019
right now user cannot declare connection options.
Reason is that always 'connection' => 'url' was set which dbal always prefers over other
connection settings. With this fix connection can be defined dbal compliant like this:
connection:
host: 'localhost'
port: '3306'
dbname: 'app'
user: 'app'
password: ''
'dsn only' works like before.
PS3-4:
- added config tests
PS5:
- if a fq dsn and connection is set dsn should be prefered
PS6:
- better naming for dbname in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now user cannot declare connection options.
Reason is that always 'connection' => 'url' was set which dbal always prefers over other
connection settings. With this fix connection can be defined dbal compliant like this:
'dsn only' works like before.
@makasim what do you think?