Skip to content

[fix] queue consumption: catch throwable for processing errors #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

macghriogair
Copy link

@macghriogair macghriogair commented Nov 9, 2020

This fixes the issue with unhandled Errors described in #1113

tbd. if this might be considered breaking backward compatibility or if I missed any important place.
Actually it should not, since \Exception extends from \Throwable. But feel free to comment & object.

@makasim
Copy link
Member

makasim commented Nov 9, 2020

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main enqueue-dev repository. It is used by Composer to allow developers to depend on specific Enqueue package.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/php-enqueue/enqueue-dev

Read the contribution guide

https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md

Thank you for your contribution!

@macghriogair
Copy link
Author

Ah, my bad! I'll change that.

@macghriogair
Copy link
Author

Closing in favor of: php-enqueue/enqueue-dev#1114

@macghriogair macghriogair deleted the bugfix/consume-catch-throwable branch November 9, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants