implement queue release delay #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
Mar 9, 2018
src/Job.php
Outdated
|
|
||
| $requeueMessage = clone $this->psrMessage; | ||
| $requeueMessage->setProperty('x-attempts', $this->attempts() + 1); | ||
|
|
||
| $this->psrContext->createProducer()->send($this->psrConsumer->getQueue(), $requeueMessage); | ||
| $this->psrContext->createProducer() | ||
| ->setDeliveryDelay($this->secondsUntil($delay)) |
There was a problem hiding this comment.
the setter can throw an exception in case delaying is not supported. I think we should $this->psrConsumer->acknowledge($this->psrMessage); before trying to requeue.
There was a problem hiding this comment.
the setter can throw an exception in case delaying is not supported.
i think we need an api for that, is it alright to have something like
trait DelayStrategyAwareTrait
{
// ..............
public function delayable()
{
return $this->delayStrategy ? true : false;
}
}
also my pr code should check for DelayStrategyAware contract`
I think we should $this->psrConsumer->acknowledge($this->psrMessage); before trying to requeue
yes i agree
makasim
reviewed
Mar 12, 2018
src/Job.php
Outdated
| $this->psrContext->createProducer()->send($this->psrConsumer->getQueue(), $requeueMessage); | ||
| $producer = $this->psrContext->createProducer(); | ||
|
|
||
| if ($producer instanceof DelayStrategyAware && $producer->delayable()) { |
There was a problem hiding this comment.
what is $producer->delayable()? There is no such method?
$producer instanceof DelayStrategyAware makes sense only for AMQP transports.
It'd be better to try always setDeliveryDelay and catch an exception DeliveryDelayNotSupported (or something like this)>
sorry i'm so clumsy, if you want to close this PR and do this in your own implementation, i'd me more than happy to do that, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$delayunit is in second