Skip to content

expressions in "query", iterable parameters #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2023
Merged

expressions in "query", iterable parameters #26

merged 6 commits into from
Jul 10, 2023

Conversation

clemzarch
Copy link
Contributor

@clemzarch clemzarch commented Jun 19, 2023 •
edited
Loading

image

image

@clemzarch clemzarch added the GTM Good to merge label Jun 19, 2023
@clemzarch clemzarch requested a review from gplanchat June 19, 2023 12:35
@clemzarch clemzarch self-assigned this Jun 19, 2023
@clemzarch clemzarch force-pushed the feature/expressions-in-query branch from f7933cd to 05ef584 Compare June 19, 2023 12:37
@clemzarch clemzarch requested a review from sebprt June 19, 2023 12:39
@clemzarch clemzarch added WIP Work in Progress and removed GTM Good to merge labels Jun 20, 2023
@clemzarch clemzarch force-pushed the feature/expressions-in-query branch from 6e7ab63 to 7531f60 Compare June 20, 2023 12:09
@clemzarch clemzarch changed the title interpret expressions in "query" when reading the configuration expressions in "query", iterable parameters Jun 20, 2023
@clemzarch clemzarch force-pushed the feature/expressions-in-query branch from 7531f60 to e5d6342 Compare June 20, 2023 12:23
@clemzarch clemzarch added GTM Good to merge and removed WIP Work in Progress labels Jun 20, 2023
@clemzarch
add option "from" to allow to bind multiple parameters even if their …
b5f38e0 
…number is unknown,

interpret expressions in "query" when reading the configuration
@clemzarch clemzarch force-pushed the feature/expressions-in-query branch from e5d6342 to b5f38e0 Compare June 20, 2023 13:28
@clemzarch clemzarch mentioned this pull request Jun 21, 2023
Closed
@clemzarch clemzarch changed the title expressions in "query", iterable parameters draft: expressions in "query", iterable parameters Jun 28, 2023
@clemzarch clemzarch marked this pull request as draft June 28, 2023 07:57
JoMessina
JoMessina reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je valide la structure et le paramétrage qui m'a l'air bon mais je n'ai pas tout compris à la logique dans les compile

@clemzarch clemzarch marked this pull request as ready for review June 29, 2023 12:43
@clemzarch clemzarch changed the title draft: expressions in "query", iterable parameters expressions in "query", iterable parameters Jun 29, 2023
@clemzarch clemzarch force-pushed the feature/expressions-in-query branch from ac92290 to 209e820 Compare June 29, 2023 14:07
sebprt
sebprt previously requested changes Jun 29, 2023
View reviewed changes
@clemzarch
handle iterable parameters for Lookup, Loader, Conditional Loader,
9b1a322 
don't do a fetchAll, the user should CONCAT if there are multiple results
@clemzarch clemzarch force-pushed the feature/expressions-in-query branch from 209e820 to 9b1a322 Compare June 30, 2023 12:38
@clemzarch clemzarch requested review from JoMessina and sebprt July 3, 2023 07:57
@gplanchat gplanchat dismissed sebprt’s stale review July 10, 2023 07:43

Outdated code

@gplanchat gplanchat merged commit 8de7414 into main Jul 10, 2023
@gplanchat gplanchat deleted the feature/expressions-in-query branch July 10, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gplanchat gplanchat gplanchat left review comments

@JoMessina JoMessina JoMessina approved these changes

@sebprt sebprt Awaiting requested review from sebprt

Assignees

@clemzarch clemzarch

Labels
GTM Good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clemzarch @gplanchat @sebprt @JoMessina