Do not suggest installation of puli via composer or error messages #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Mar 5, 2021
naderman
force-pushed
the
remove-puli-recommendation
branch
from
bf00d72 to
2b98f18
Compare
naderman
force-pushed
the
remove-puli-recommendation
branch
from
2b98f18 to
658a1aa
Compare
|
Thank you |
|
i added a note to the changelog for this #196 |
|
Sorry to see that project die. :( |
|
me too, but we help nobody if we pretend it did not die. if it is resurrected, i am happy to add support back in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Puli has not been modified in 5 years, it's abandoned, the website is down and it's not compatible with Composer v2, it should be removed from this project.
More urgently it is currently the first suggestion for why discovery may not work, leading novice users to install puli to fix this error message, which just makes things worse.
So this PR for now just removes the suggestion from composer.json and the error message.
Next step would be proper full deprecation and eventually removal.
Checklist