-
Notifications
You must be signed in to change notification settings - Fork 10
Allow PHP 8 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PHP 8 #19
Conversation
Note that the actions stuff is working correctly, on my fork, however it just won;t show on this PR until the actions config is merged to master. GitHub don't run actions when the target branch (for whatever reason). |
In particular, I chose actions because of the fact we can write 8.0 for the PHP version. Travis refuse to do this... which is stupid because if we write nightly, we'd only have to update the config later, because we really did want 8.0. |
NB The actions run on my fork is: https://github.com/GrahamCampbell/promise/actions/runs/160365041. The coverage stuff should work on this repo. My fork just isn't enabled on scrutinizer. |
i deleted the travis-ci hook |
Travis wouldn't run anyway since I deleted its config file from the repo. :) |
i assumed it would start to error |
It just skips builds that have no config. It's useful when a repo has some branches only on travis and some only on actions. |
🎉