Skip to content

Allow PHP 8 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2020
Merged

Allow PHP 8 #19

merged 8 commits into from
Jul 7, 2020

Conversation

GrahamCampbell
Copy link
Contributor

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
License MIT

🎉

@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 7, 2020 08:27
@GrahamCampbell
Copy link
Contributor Author

Note that the actions stuff is working correctly, on my fork, however it just won;t show on this PR until the actions config is merged to master. GitHub don't run actions when the target branch (for whatever reason).

@GrahamCampbell
Copy link
Contributor Author

GrahamCampbell commented Jul 7, 2020

In particular, I chose actions because of the fact we can write 8.0 for the PHP version. Travis refuse to do this... which is stupid because if we write nightly, we'd only have to update the config later, because we really did want 8.0.

@GrahamCampbell
Copy link
Contributor Author

GrahamCampbell commented Jul 7, 2020

NB The actions run on my fork is: https://github.com/GrahamCampbell/promise/actions/runs/160365041. The coverage stuff should work on this repo. My fork just isn't enabled on scrutinizer.

@dbu dbu merged commit dcc6fad into php-http:master Jul 7, 2020
@GrahamCampbell GrahamCampbell deleted the patch-2 branch July 7, 2020 09:20
@dbu
Copy link
Contributor

dbu commented Jul 7, 2020

i deleted the travis-ci hook

@GrahamCampbell
Copy link
Contributor Author

Travis wouldn't run anyway since I deleted its config file from the repo. :)

@dbu
Copy link
Contributor

dbu commented Jul 7, 2020

i assumed it would start to error

@GrahamCampbell
Copy link
Contributor Author

It just skips builds that have no config. It's useful when a repo has some branches only on travis and some only on actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants