Skip to content

Add qos_network_id option to ports create/update #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tduncan8
Copy link

add qos_network_id to ports create/update to allow this field to be readable/writeable https://docs.openstack.org/api-ref/network/v2/index.html

@k0ka
Copy link
Member

k0ka commented Mar 16, 2025

Hello,

Thank you for the PR. Could you create some tests for this feature? At least add a unit test with some real response from the server to make sure it is working properly. Like this:
https://github.com/php-opencloud/openstack/blob/master/tests/unit/Networking/v2/Models/PortTest.php#L50
https://github.com/php-opencloud/openstack/blob/master/tests/unit/Networking/v2/Fixtures/port_get.resp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants