-
Notifications
You must be signed in to change notification settings - Fork 71
Watch changes on files that are resources within the container #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The tests are failing because the Container is missing in the Mocks and PHPStan does not like the instanceof on a String |
I'd maybe wrap all that code in a you also have a special function |
I still dont see the point why the reloading is blocked when debug is disabled.. But i added the two ideas :D |
❤️ this PR (I was actually planning to do something similar because I keep needing this) |
Looks like the failure is unrelated but still new. I would appreciate an independent review of this pr (@dnna ?). |
Kicked of a rebuild |
OK, now it breaks because it tries to access $container->containerDir in the new code. This should be fixable by simply adding a |
@dnna the phpstan issue is already gone :) I add the $containerDir now... |
And another one merged. Thanks for PR and review! |
See issue: #147