Add FreeBSD ZTS nightly build #18959
Open
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arnaud-lb
commented
Jun 27, 2025
arnaud-lb
commented
- Will be useful for Fix linker failure when building opcache statically #18939.
- Includes Fix pcntl_rfork() / pcntl_forkx() with zend-max-execution-timers #18958.
|
Is the change in the extension necessary if you have these in the other PR ? |
|
I plan to rebase on master once the other PR is merged, so that only the first commit remains in this PR |
|
Ok. maybe the build aspect deserves a review from @iluuu1994 ? |
iluuu1994
reviewed
Jun 27, 2025
Comment on lines
+1058
to
+1060
| include: | ||
| - zts: false | ||
| - zts: true |
There was a problem hiding this comment.
Suggested change
| include: | |
| - zts: false | |
| - zts: true | |
| zts: [true, false] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.