Skip to content

Fix GH-13220: stream_socket_accept() timeout sometimes does not work #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix GH-13220: stream_socket_accept() timeout sometimes does not work #19252

wants to merge 1 commit into from
+128 −17

Conversation

bukka
Copy link
Member

@bukka bukka commented Jul 26, 2025

This should fix race condition between poll and accept.

@bukka
Copy link
Member Author

bukka commented Jul 26, 2025

I think I will need to get my unit tests merged first as this might be quite hard to test otherwise.

@bukka
Copy link
Member Author

bukka commented Jul 26, 2025

This is not a big issue so targeting just master.

@bukka
Copy link
Member Author

bukka commented Jul 26, 2025

It would be also good to expose this timer diffs as they are also used in OpenSSL ext so some minor refactoring would be good here.

@bukka bukka mentioned this pull request Jul 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bukka