Skip to content

Updates phpparser to version 3.0 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented May 23, 2017

This is a BC break. We drop support for php5.

All tests are passing, but I'm sure that that doesn't say any thing. We will have to add tests to be sure everything works as expected.

This is a BC break. We drop support for php5.
@jaapio jaapio added this to the v4.0.0 milestone May 23, 2017
@ashnazg
Copy link
Member

ashnazg commented May 26, 2017

I wonder... would an interim bump to 2.0 here give us a chance to solve the file-level docblock issue in phpDocumentor in the 2.x line?

@jaapio
Copy link
Member Author

jaapio commented May 26, 2017

Php parser v2 requires php 5.4. That would either be a bc break

@jaapio jaapio requested a review from mvriel June 19, 2017 08:42
@max-voloshyn
Copy link

I would like to use @phpstan (in addition to this library) that requires "nikic/php-parser": "^3.0.2" so these changes are much appreciated 👍

@theofidry
Copy link

@max-voloshin you shouldn't install static analysis tools in your project root composer.json but either use a PHAR or install it in a separate composer.json which some plugins like bamarni/composer-bin-plugin helps you to do

@jaapio
Copy link
Member Author

jaapio commented Sep 28, 2017

I'm closing this pr because we are moving forward with phpdocumentor v3 at the moment. There is no reason to support this old implementation of the reflection library anymore.

@jaapio jaapio closed this Sep 28, 2017
@jaapio jaapio deleted the feature/bump-phpparser branch September 28, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants