Skip to content

Fetch GnuPG key from keyserver #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2018
Merged

Fetch GnuPG key from keyserver #149

merged 2 commits into from
Apr 18, 2018

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Feb 13, 2018 •
edited
Loading

Notes:

  • Fetching the key from a keyserver make sure that changes (e.g. revocation) are applied
  • This also removes the keyring binary from this repo
  • Code style is now more consistent
  • Moving the installation of required software on top may speed up installation of other dependencies (if they share some) and caches this step

@stale
Copy link

stale bot commented Apr 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 14, 2018
@J0WI
Copy link
Contributor Author

J0WI commented Apr 17, 2018

@nijel can I get some feedback on this?

@stale stale bot removed the wontfix label Apr 17, 2018
@nijel nijel self-assigned this Apr 18, 2018
@nijel nijel merged commit d42e7c8 into phpmyadmin:master Apr 18, 2018
@nijel
Copy link
Contributor

nijel commented Apr 18, 2018

Merged, thanks for your contribution!

@nijel
Copy link
Contributor

nijel commented Apr 18, 2018

Apparently it's not the most reliable keyserver: gpg: keyserver receive failed: Address not available, see https://travis-ci.org/phpmyadmin/docker/jobs/367994869#L1737

nijel added a commit that referenced this pull request Apr 18, 2018
@nijel
Switch to gnupg.net keyservers
92a5a76 
The old one seem not to be accessible sometimes.

See #149

Signed-off-by: Michal Čihař <[email protected]>
@nijel
Copy link
Contributor

nijel commented Apr 18, 2018

I've tried to use different keyserver, but I'm not really sure relying on external service here was a good idea. People end up doing workaround like in nodejs/docker-node#380 (comment)

nijel added a commit that referenced this pull request Apr 18, 2018
@nijel
Use more pgp keyservers to download the key
2fe5947 
Apparently this is only way to make this reliable.

See #149

Signed-off-by: Michal Čihař <[email protected]>
@J0WI
Copy link
Contributor Author

J0WI commented Apr 19, 2018

That's a common issue: docker-library/postgres#262 (comment)

@J0WI J0WI deleted the enhancements2 branch April 19, 2018 13:51
@J0WI
Copy link
Contributor Author

J0WI commented Apr 19, 2018

@nijel how about using travis_retry instead of 2fe5947?

@nijel
Copy link
Contributor

nijel commented Apr 23, 2018

travis_retry will not help in case there is some issue on the network (eg. the ivp4/ipv6 issue mentioned above), that's why I've decided to try different keyservers instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J0WI @nijel