Report bool properties as too wide when only used with true/false #4243
+152
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 14, 2025
build/phpstan.neon
Outdated
| - | ||
| identifier: property.unusedType | ||
| message: '#\(bool\) is never assigned (false|true) so it can be removed from the property type#' | ||
| path: ../tests/PHPStan/*RuleTest.php | ||
|
|
There was a problem hiding this comment.
we cannot use true/false property types in tests, as the simple-downgrader cannot downgrade them.
therefore ignore the errors
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Aug 15, 2025
There was a problem hiding this comment.
- This doesn't have to be limited to properties
- This doesn't have to be limited to PHP versions with native standalone
true/falsetypes support. We have PHPDocs after all.
There are many TooWide* rules with duplicated logic and maybe some variances in the logic. First we should refactor and deduplicate the logic where possible.
Then we could introduce a new bleeding edge toggle to enable reporting "too wide bool".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13384