Prevent duplicate super-global-variable detection #4662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 24, 2025
src/Analyser/MutatingScope.php
Outdated
Comment on lines
5008
to
5011
| if (!$expr->hasAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME)) { | ||
| $expr->setAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME, $nodeFinder->findFirst($expr, $globalVariableCallback) !== null); | ||
| } | ||
| if ($expr->getAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME) !== null) { |
Contributor
Author
There was a problem hiding this comment.
maybe super global variables are rare enough that we could instead remember with a bool property on Scope, whether the current scope contains any super-global variable.
if not, skip this whole node-finding at this stage.
another way could be using a NodeVisitor
Member
|
Why did you close this? 😊 |
Contributor
Author
|
it contained a bug :) - re-opened but the numbers are not as good as initially thought (updated the description) |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php bin/phpstan analyse src/Analyser/ src/Rules/ -v --debugbefore this PR:
after this PR: