remove extranious selector that prevents matching issues #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I noted when restarting a partial import. If the process created an issue but was interrupted before finishing the issue import, restarting the import will not match the partial import and will create a new issue. This "messes up" the issue numbering. |
|
Did you find a way to resolve the partial import issue? |
spruce
reviewed
Jan 26, 2025
| @@ -159,7 +159,7 @@ export class GithubHelper { | |||
| owner: this.githubOwner, | |||
| repo: this.githubRepo, | |||
| state: 'all', | |||
| labels: 'gitlab merge request', | |||
| // labels: 'gitlab merge request', | |||
There was a problem hiding this comment.
Could you annotate the removal with the reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restarting a migration will fail to recognize existing github issues since the selector is looking for labels. Removing that enables the correct behaviour.