Fix unbalanced diagnostics pragma#33
Merged
keith-packard merged 1 commit intopicolibc:masterfrom Apr 6, 2020
Merged
Conversation
Clang 9 is complaining about this and the code appears to be wrong.
Collaborator
|
Thanks for the fix -- GCC doesn't even warn about this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 9 is complaining about this and the code appears to be wrong.
Note that I'm using a custom build system (to avoid external dependencies, among other reasons) so perhaps there is something different in my setup that causes this error to appear.
Sidenote: thanks a lot for your work on picolibc! It's being used now as a C library in TinyGo for most bare metal targets: tinygo-org/tinygo#871