Skip to content

Fix unbalanced diagnostics pragma#33

Merged
keith-packard merged 1 commit intopicolibc:masterfrom
aykevl:fix-pragma-push
Apr 6, 2020
Merged

Fix unbalanced diagnostics pragma#33
keith-packard merged 1 commit intopicolibc:masterfrom
aykevl:fix-pragma-push

Conversation

@aykevl
Copy link
Copy Markdown

@aykevl aykevl commented Apr 6, 2020

Clang 9 is complaining about this and the code appears to be wrong.

In file included from /home/ayke/src/github.com/tinygo-org/tinygo/lib/picolibc/newlib/libm/common/s_expm1.c:145:
/home/ayke/src/github.com/tinygo-org/tinygo/lib/picolibc/newlib/libm/common/math_config.h:222:24: error: pragma diagnostic pop could not pop, no matching push [-Werror,-Wunknown-pragmas]
#pragma GCC diagnostic pop
                       ^
1 error generated.

Note that I'm using a custom build system (to avoid external dependencies, among other reasons) so perhaps there is something different in my setup that causes this error to appear.


Sidenote: thanks a lot for your work on picolibc! It's being used now as a C library in TinyGo for most bare metal targets: tinygo-org/tinygo#871

Clang 9 is complaining about this and the code appears to be wrong.
@keith-packard keith-packard merged commit 4967d8e into picolibc:master Apr 6, 2020
@keith-packard
Copy link
Copy Markdown
Collaborator

Thanks for the fix -- GCC doesn't even warn about this issue.

@aykevl aykevl deleted the fix-pragma-push branch April 6, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants