Optional param before required #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I made the 3th param optional, this shouldn't break anything, since that param is not used within the closure. I also added the question mark after the Please let me know if there is anything that i'm missing! |
Contributor
Author
|
Is someone able to pickup this small update? |
Optional param
Use the accept language param
Contributor
Member
|
Weird that our code does not complain about this, because we use PHP 8.3 for a while. But thanks for fixing. |
jobjen02
pushed a commit
to jobjen02/bol-retailer-php-client
that referenced
this pull request
Jul 5, 2024
Optional param before required
Member
|
Made a new release with this fix: https://github.com/picqer/bol-retailer-php-client/releases/tag/v10.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optional parameter must be defined after the required parameters. This has been required since php 8.1.
Due to this issue we encountered a PHP error.
See:
https://arc.net/l/quote/xqkamcmp