Fix getCommissionRates by adding response type #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no response type for the getCommissionRates which makes it impossible for the library to decode into the corresponding model. Added code 207 as documented by Bol.
WoutervanderLoopNL
added a commit
to WoutervanderLoopNL/bol-retailer-php-client
that referenced
this pull request
Sep 16, 2024
WoutervanderLoopNL
added a commit
to WoutervanderLoopNL/bol-retailer-php-client
that referenced
this pull request
Sep 16, 2024
Contributor
|
not edit the Client directly, because it will override every new generation. its needed to be done in the ClientGenerator. |
casperbakker
added a commit
that referenced
this pull request
Sep 18, 2024
Added 207 response type. Fixes: #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no response type for the getCommissionRates which makes it impossible for the library to decode the response into the corresponding model. Added code 207 as documented by Bol.