Feature Request: Support for Custom Authorization Parameters

[oschrenk]

Problem

It seems ortie does not support query parameters in authorization endpoint URL. That prohibits getting a refresh token from Google.

But AFAIU Google requires additional parameters to enable refresh token support.

Where the issue occurs:

In src/auth/get.rs:80-81, ortie replaces the entire query string with default values

uri.set_query(Some(&request_params.to_form_url_encoded_string()));

So even if I try to set

  endpoints.authorization = "https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent"

those parameters get stripped away

But.... f

From https://developers.google.com/identity/protocols/oauth2/web-server:

The refresh token is only returned if your application set the access_type parameter to offline in the initial request to Google's authorization server.
Additionally, if the user has previously authorized the application, you need prompt=consent to force re-authorization and receive a new refresh token.

I had claude code change the code to inject these extra query params via a toml configuration. It works for me (I now get a refresh token) but since it's all AI I rather not make that a PR.

Thoughts?

[soywod]

Merging query params could be a solution?

[oschrenk]

It's a design decision. What if ortie tries to replace a parameter the user specificed? Should it silently replace it? Warn in terminal? Just fail?

[soywod]

Ortie sets up default query parameters. So any user query param should override them. I just pushed a fix on master, seems to work better. Let me know.

EDIT: release build is available from the CI

[oschrenk]

Google Oauth with refresh now works on master with endpoints.authorization = "https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent" being set.

Happy to ditch my personal fork . Would you be able to cut a new release

[soywod]

Would you be able to cut a new release

Yes, it should come very soon, stay tuned.

[soywod]

v1.0.0 released: https://github.com/pimalaya/ortie/releases/tag/v1.0.0