Skip to content

Add new GC API #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 8 commits into from
May 12, 2025
Merged

Add new GC API #1288

ti-chi-bot merged 8 commits into from
May 12, 2025

Conversation

@MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Jan 7, 2025

@MyonKeminta
Add new GC API
7e131df 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot requested review from nolouch and terry1purcell January 7, 2025 08:23
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 7, 2025
@MyonKeminta MyonKeminta mentioned this pull request Jan 6, 2025
Closed
24 tasks
@MyonKeminta MyonKeminta mentioned this pull request Apr 10, 2025
Merged
This was referenced Apr 21, 2025
Merged
Merged
Closed
@MyonKeminta
Fix missing field
6653a56 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Merge branch 'master' of https://github.com/pingcap/kvproto into m/ad…
5ab5a37 
…d-new-gc-api
@MyonKeminta MyonKeminta marked this pull request as ready for review May 6, 2025 06:34
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2025

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2025

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-12 07:43:52.766882572 +0000 UTC m=+344698.914843774: ☑️ agreed by JmPotato.
  • 2025-05-12 08:10:15.599625645 +0000 UTC m=+346281.747586863: ☑️ agreed by rleungx.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, JmPotato, okJiang, rleungx, ystaticy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit 1174a93 into pingcap:master May 12, 2025
5 checks passed
@MyonKeminta MyonKeminta deleted the m/add-new-gc-api branch May 12, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@ystaticy ystaticy ystaticy approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@okJiang okJiang okJiang approved these changes

@rleungx rleungx rleungx approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@terry1purcell terry1purcell Awaiting requested review from terry1purcell

Assignees

No one assigned

Labels

approved lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MyonKeminta @JmPotato @ystaticy @cfzjywxk @okJiang @rleungx