Skip to content

Conversation

@MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #58720

Problem Summary:

This PR adds implementation of the new GC APIs for the mock PD in unistore.
This makes it possible for integration tests in client-go repo to be run successfully.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2025
@tiprow
Copy link

tiprow bot commented Jun 5, 2025

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2025
@MyonKeminta
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Jun 6, 2025

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@cfzjywxk cfzjywxk requested review from cfzjywxk and tiancaiamao June 6, 2025 06:34
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Jun 6, 2025

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 86.44860% with 29 lines in your changes missing coverage. Please review.

Project coverage is 73.6376%. Comparing base (5ce93d1) to head (ec8d723).
Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61529        +/-   ##
================================================
+ Coverage   73.0956%   73.6376%   +0.5419%     
================================================
  Files          1729       1731         +2     
  Lines        480695     483651      +2956     
================================================
+ Hits         351367     356149      +4782     
+ Misses       107792     105842      -1950     
- Partials      21536      21660       +124     
Flag Coverage Δ
integration 42.6173% <19.6261%> (?)
unit 72.3838% <86.4486%> (+0.0257%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.9813% <ø> (+0.0236%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jun 6, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 6, 2025
@MyonKeminta MyonKeminta marked this pull request as ready for review June 6, 2025 11:43
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-06 11:45:33.422459775 +0000 UTC m=+9911.650775038: ☑️ agreed by cfzjywxk.
  • 2025-06-06 11:49:49.902704673 +0000 UTC m=+10168.131019930: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit 6f1f815 into pingcap:master Jun 6, 2025
24 checks passed
@MyonKeminta MyonKeminta deleted the m/mock-pd-new-gc-api branch June 9, 2025 03:58
joechenrh pushed a commit to joechenrh/tidb that referenced this pull request Jun 10, 2025
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants