Skip to content

Conversation

@RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Jun 9, 2025

What problem does this PR solve?

Issue Number: close #61592

Problem Summary:

This problem is already fixed in master after restore refactor. This is only a test enhancement.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2025
@tiprow
Copy link

tiprow bot commented Jun 9, 2025

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR RidRisR changed the title br: enhance table existence test br: enhance table existence check Jun 9, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-09 10:09:52.322689088 +0000 UTC m=+263370.551004347: ☑️ agreed by Leavrth.
  • 2025-06-09 10:11:03.965208154 +0000 UTC m=+263442.193523418: ☑️ agreed by BornChanger.

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5970%. Comparing base (ed86935) to head (5111a7e).
Report is 94 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61596        +/-   ##
================================================
+ Coverage   73.1713%   74.5970%   +1.4256%     
================================================
  Files          1726       1748        +22     
  Lines        479096     494521     +15425     
================================================
+ Hits         350561     368898     +18337     
+ Misses       107042     103150      -3892     
- Partials      21493      22473       +980     
Flag Coverage Δ
integration 46.1216% <ø> (?)
unit 72.3690% <ø> (-0.0578%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 59.5157% <ø> (+11.9406%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot merged commit 07e1f41 into pingcap:master Jun 9, 2025
23 checks passed
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jun 10, 2025
@RidRisR RidRisR deleted the fixdup branch June 10, 2025 09:32
@YuJuncen YuJuncen added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jun 10, 2025
@YuJuncen
Copy link
Contributor

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #61624.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 10, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #61625.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #61626.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #61627.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 10, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #61628.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

br: there is no table duplicate check in full restore with filter

5 participants