Skip to content

Comments

[DNM] *: add prefetch for each column#65861

Closed
joechenrh wants to merge 1 commit intopingcap:release-8.5from
joechenrh:prefetch-parquet
Closed

[DNM] *: add prefetch for each column#65861
joechenrh wants to merge 1 commit intopingcap:release-8.5from
joechenrh:prefetch-parquet

Conversation

@joechenrh
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Ruihao Chen <joechenrh@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. component/statistics sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2026
@joechenrh joechenrh changed the base branch from master to release-8.5 January 28, 2026 03:44
@tiprow
Copy link

tiprow bot commented Jan 28, 2026

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 28, 2026

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133, benjamin2037, benmeadowcroft, d3hunter, time-and-fate, xuhuaiyu, yujuncen for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@1fa258b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #65861   +/-   ##
================================================
  Coverage               ?   30.2376%           
================================================
  Files                  ?       1593           
  Lines                  ?     453604           
  Branches               ?          0           
================================================
  Hits                   ?     137159           
  Misses                 ?     300579           
  Partials               ?      15866           
Flag Coverage Δ
integration 30.2376% <85.7142%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 35.8085% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 28, 2026

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lightning-integration-test a28e79c link true /test pull-lightning-integration-test
pull-integration-e2e-test a28e79c link true /test pull-integration-e2e-test
pull-br-integration-test a28e79c link true /test pull-br-integration-test
pull-mysql-client-test-next-gen a28e79c link true /test pull-mysql-client-test-next-gen
pull-build-next-gen a28e79c link true /test pull-build-next-gen
pull-unit-test-ddlv1 a28e79c link true /test pull-unit-test-ddlv1
pull-integration-ddl-test a28e79c link true /test pull-integration-ddl-test
pull-mysql-client-test a28e79c link true /test pull-mysql-client-test
pull-integration-realcluster-test-next-gen a28e79c link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen a28e79c link true /test pull-unit-test-next-gen
idc-jenkins-ci-tidb/build a28e79c link true /test build
idc-jenkins-ci-tidb/check_dev a28e79c link true /test check-dev
idc-jenkins-ci-tidb/unit-test a28e79c link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joechenrh joechenrh closed this Feb 9, 2026
@joechenrh joechenrh deleted the prefetch-parquet branch February 9, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dumpling This is related to Dumpling of TiDB. component/statistics do-not-merge/cherry-pick-not-approved do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant