Skip to content

refactor(test)!: migrate tests to node:test and upgrade deps #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Puppo wants to merge 9 commits into from
Closed

refactor(test)!: migrate tests to node:test and upgrade deps #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f17c273
refactor(test): migrate tests from tap to node:test
Puppo Dec 12, 2025
1c8433f
chore(lint): migrate to neostandard and lefthook
Puppo Dec 12, 2025
3bda57f
chore(ci): update Node.js versions to 20, 22, 24
Puppo Dec 12, 2025
8fc6915
chore(lint): remove TypeScript config option
Puppo Dec 12, 2025
ad24e37
chore: remove lefthook configuration and dependency
Puppo Dec 12, 2025
acb81a4
chore(lint): sync ignores with .gitignore via neostandard
Puppo Dec 12, 2025
36a1eec
test: replace commented passes with assertions
Puppo Dec 12, 2025
35debde
refactor: use node: prefix for core module imports
Puppo Dec 12, 2025
a879a35
fix(scripts): update test script glob pattern
Puppo Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .eslintrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [16, 18, 19]
node-version: [20, 22, 24]
steps:
- name: Check out repo
uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion .taprc.yml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/usr/bin/env node
'use strict'

const path = require('path')
const fs = require('fs')
const path = require('node:path')
const fs = require('node:fs')
const realPath = fs.realpathSync(__dirname)
const script = path.join(realPath, 'psyslog.js')

Expand Down
7 changes: 7 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'use strict'

const neostandard = require('neostandard')

module.exports = neostandard({
ignores: neostandard.resolveIgnoresFromGitignore(),
})
32 changes: 13 additions & 19 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"homepage": "https://github.com/pinojs/pino-syslog",
"main": "lib/transport.js",
"scripts": {
"test": "npm run lint && tap --no-cov 'test/**/*.test.js'",
"test": "npm run lint && node --test test/*.test.js",
"lint": "eslint .",
"lint:fix": "eslint --fix ."
},
Expand All @@ -28,26 +28,20 @@
"test"
],
"devDependencies": {
"eslint": "^8.31.0",
"eslint-config-standard": "^17.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-n": "^15.6.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.1.1",
"pino": "^8.8.0",
"pino-socket": "^7.3.0",
"pre-commit": "^1.2.2",
"tap": "^16.3.2"
"eslint": "^9.39.1",
"neostandard": "^0.12.2",
"pino": "^10.1.0",
"pino-socket": "^7.4.0"
Copy link
Member

@jsumners jsumners Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are blocked until I get the next pino-socket ready (currently fighting with tests).

Copy link
Member

@jsumners jsumners Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Puppo if you'd like to help, I'm trying to figure out why I can't get the issue5 test to feed data to stdin https://github.com/pinojs/pino-socket/compare/new-major

Copy link
Author

@Puppo Puppo Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsumners done pinojs/pino-socket#108

},
"dependencies": {
"fast-json-parse": "^1.0.2",
"fast-safe-stringify": "^2.0.2",
"luxon": "^3.2.1",
"nopt": "^7.0.0",
"pino-abstract-transport": "^1.0.0",
"pump": "^3.0.0",
"sonic-boom": "^3.2.1",
"split2": "^4.1.0",
"fast-json-parse": "^1.0.3",
"fast-safe-stringify": "^2.1.1",
"luxon": "^3.7.2",
"nopt": "^9.0.0",
"pino-abstract-transport": "^3.0.0",
"pump": "^3.0.3",
"sonic-boom": "^4.2.0",
"split2": "^4.2.0",
"through2": "^4.0.2"
}
}
4 changes: 2 additions & 2 deletions psyslog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict'

const nopt = require('nopt')
const path = require('path')
const path = require('node:path')
const pump = require('pump')
const split2 = require('split2')
const parseJson = require('fast-json-parse')
const { buildOptions } = require('./lib/utils')
const { buildOptions } = require('./lib/utils.js')

const longOpts = {
modern: Boolean,
Expand Down
Loading