Skip to content

Conversation

@smilu97
Copy link
Contributor

@smilu97 smilu97 commented May 23, 2023

resolves #9983

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #9984 (6131bae) into master (7405e18) will decrease coverage by 0.08%.
The diff coverage is 10.28%.

@@             Coverage Diff              @@
##             master    #9984      +/-   ##
============================================
- Coverage     38.65%   38.58%   -0.08%     
- Complexity    11603    11611       +8     
============================================
  Files          3570     3571       +1     
  Lines         93043    93275     +232     
  Branches      10261    10310      +49     
============================================
+ Hits          35964    35987      +23     
- Misses        54001    54206     +205     
- Partials       3078     3082       +4     
Impacted Files Coverage Δ
...rvice/CollectorActiveThreadCountServiceConfig.java 0.00% <ø> (ø)
.../collector/service/ClusterAgentCommandService.java 0.00% <0.00%> (ø)
...int/realtime/dto/mapper/ThriftToGrpcConverter.java 0.00% <0.00%> (ø)
...oint/realtime/dto/mapper/grpc/ATDDemandMapper.java 0.00% <0.00%> (ø)
...oint/realtime/dto/mapper/grpc/ATDSupplyMapper.java 0.00% <0.00%> (ø)
...altime/dto/mapper/grpc/ActiveThreadDumpMapper.java 0.00% <0.00%> (ø)
...npoint/realtime/dto/mapper/grpc/GrpcDtoMapper.java 0.00% <0.00%> (ø)
...pinpoint/realtime/dto/mapper/grpc/MapperUtils.java 0.00% <0.00%> (ø)
...int/realtime/dto/mapper/grpc/ThreadDumpMapper.java 0.00% <0.00%> (ø)
...hread/count/dao/ActiveThreadCountWebDaoConfig.java 0.00% <ø> (ø)
... and 13 more

... and 5 files with indirect coverage changes

@smilu97 smilu97 force-pushed the 9983_thrift branch 8 times, most recently from fd25c84 to d8041ad Compare May 30, 2023 06:48
@smilu97 smilu97 merged commit 8e3ad78 into pinpoint-apm:master May 30, 2023
@smilu97 smilu97 deleted the 9983_thrift branch May 30, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict use of thrift dto in realtime module

1 participant