Use new GDB 16.2 #154
Use new GDB 16.2 #154
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update introduces several enhancements and reorganizations across configuration and platform management files. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PlatformConfig (platform.py)
participant ToolchainMapping
participant DebugToolInstaller
User->>PlatformConfig: Initiate package configuration
PlatformConfig->>ToolchainMapping: Retrieve MCU-specific toolchain/debug mapping
PlatformConfig->>PlatformConfig: Iterate over mapping to enable required toolchains
PlatformConfig->>DebugToolInstaller: Install debug tools and OpenOCD if needed
DebugToolInstaller->>PlatformConfig: Return installation status
PlatformConfig->>User: Complete configuration
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
examples/arduino-wifiscan/platformio.ini (1)
15-50: Reduce duplication with a shared[env]base sectionAll new environments share identical
platform,framework,upload_protocol, andmonitor_speedentries. A small refactor keeps the file compact and makes future tweaks less error-prone:[env] platform = espressif32 framework = arduino upload_protocol = esp-builtin monitor_speed = 115200 [env:esp-wrover-kit] board = esp-wrover-kit [env:esp32-s2] board = esp32-s2-saola-1 …platform.py (1)
74-78: Broaden exception handling duringpackage.jsoncopyGood call adding error handling.
shutil.copyfilecan also raisePermissionErroror a genericOSError(e.g. on read-only filesystems). Catching the wider tuple prevents an early abort while still surfacing the underlying issue.- except FileNotFoundError as e: - sys.stderr.write(f"Error copying tool package file: {e}\n") + except (FileNotFoundError, PermissionError, OSError) as e: + sys.stderr.write(f"Error copying tool package file: {e}\n")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
examples/arduino-wifiscan/platformio.ini(1 hunks)platform.json(1 hunks)platform.py(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (19)
- GitHub Check: build (macos-15, examples/arduino-blink)
- GitHub Check: build (macos-15, examples/espidf-arduino-matter-light)
- GitHub Check: build (windows-latest, examples/espidf-storage-sdcard)
- GitHub Check: build (windows-latest, examples/arduino-zigbee-switch)
- GitHub Check: build (windows-latest, examples/espidf-hello-world)
- GitHub Check: build (ubuntu-24.04, examples/espidf-coap-server)
- GitHub Check: build (windows-latest, examples/espidf-arduino-blink)
- GitHub Check: build (windows-latest, examples/arduino-matter-light)
- GitHub Check: build (windows-latest, examples/tasmota)
- GitHub Check: build (ubuntu-24.04, examples/espidf-peripherals-uart)
- GitHub Check: build (windows-latest, examples/arduino-zigbee-light)
- GitHub Check: build (ubuntu-24.04, examples/espidf-blink)
- GitHub Check: build (ubuntu-24.04, examples/tasmota)
- GitHub Check: build (ubuntu-24.04, examples/espidf-arduino-blink)
- GitHub Check: build (ubuntu-24.04, examples/espidf-arduino-matter-light)
- GitHub Check: build (windows-latest, examples/arduino-wifiscan)
- GitHub Check: build (windows-latest, examples/arduino-usb-keyboard)
- GitHub Check: build (ubuntu-24.04, examples/arduino-blink)
- GitHub Check: build (ubuntu-24.04, examples/arduino-wifiscan)
🔇 Additional comments (1)
platform.py (1)
145-149: Condition misses the commonbuild_type = debugvariant
variables.get("build_type")returns the string value ("debug"), yet PlatformIO sets"build_type"to that same literal.
However, many workflows rely on the boolean testif build_type == "debug":.
To be future-proof, gate on the exact value:- if (variables.get("build_type") or "debug" in "".join(targets)) ... + if (variables.get("build_type") == "debug" or "debug" in "".join(targets)) ...
Description:
Related issue (if applicable): fixes #
Checklist:
Summary by CodeRabbit
New Features
Chores