Handle nil TURN addresses in retransmissions#450
Merged
Sean-Der merged 1 commit intopion:masterfrom Apr 17, 2025
Merged
Conversation
Member
|
This LGTM @amanakin! Would it be possible to add a unit test to this? This change could easily be undone, and start causing you to break again :/ |
Member
Author
|
Good point @Sean-Der! Added tests for happy-path with and w/o retransmissions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 66.16% 67.43% +1.26%
==========================================
Files 43 43
Lines 3083 3083
==========================================
+ Hits 2040 2079 +39
+ Misses 876 843 -33
+ Partials 167 161 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
561c478 to
dda1730
Compare
Sean-Der
approved these changes
Apr 17, 2025
Member
|
Thank you @amanakin :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle nil TURN addresses in retransmissions
In certain scenarios, the
Tofield of a transaction can be nil (nil TURN address of theClient).