Skip to content

Handle nil TURN addresses in retransmissions#450

Merged
Sean-Der merged 1 commit intopion:masterfrom
amanakin:allow_empty_turn_addr
Apr 17, 2025
Merged

Handle nil TURN addresses in retransmissions#450
Sean-Der merged 1 commit intopion:masterfrom
amanakin:allow_empty_turn_addr

Conversation

@amanakin
Copy link
Member

Description

Handle nil TURN addresses in retransmissions

In certain scenarios, the To field of a transaction can be nil (nil TURN address of the Client).

@Sean-Der
Copy link
Member

This LGTM @amanakin!

Would it be possible to add a unit test to this? This change could easily be undone, and start causing you to break again :/

@amanakin
Copy link
Member Author

Good point @Sean-Der! Added tests for happy-path with and w/o retransmissions.
Couldn't find a better way to cause timeout, only setting 1ns rto.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.43%. Comparing base (381c8ad) to head (dda1730).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   66.16%   67.43%   +1.26%     
==========================================
  Files          43       43              
  Lines        3083     3083              
==========================================
+ Hits         2040     2079      +39     
+ Misses        876      843      -33     
+ Partials      167      161       -6     
Flag Coverage Δ
go 67.43% <100.00%> (+1.26%) ⬆️
wasm 26.59% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanakin amanakin force-pushed the allow_empty_turn_addr branch from 561c478 to dda1730 Compare April 17, 2025 09:29
@Sean-Der Sean-Der merged commit 3c4173e into pion:master Apr 17, 2025
14 checks passed
@Sean-Der
Copy link
Member

Thank you @amanakin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants