Skip to content

OnICEConnectionStateChange should return ICEConnectionState #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
backkem opened this issue Feb 20, 2019 · 0 comments
Closed

OnICEConnectionStateChange should return ICEConnectionState #422

backkem opened this issue Feb 20, 2019 · 0 comments
Assignees
@backkem

Comments

@backkem
Copy link
Member

backkem commented Feb 20, 2019 •
edited
Loading

Instead of returning ice.ConnectionState the OnICEConnectionStateChange callback should return a webrtc.ICEConnectionState.
@backkem backkem self-assigned this Feb 20, 2019
@backkem backkem changed the title OnICEConnectionStateChange should return IceConnectionState OnICEConnectionStateChange should return ICEConnectionState Feb 20, 2019
backkem added a commit that referenced this issue Feb 20, 2019
@backkem
API: OnICEConnectionStateChange returns ICEConnectionState
981c116 
OnICEConnectionStateChange now return a ICEConnectionState instead of
ice.ConnectionState.
Resolves #422
@backkem backkem mentioned this issue Feb 20, 2019
Merged
@backkem backkem added the review label Feb 20, 2019
backkem added a commit that referenced this issue Feb 20, 2019
@backkem
API: Avoid exposing pkg/ice
0267180 
OnICEConnectionStateChange now return a ICEConnectionState instead of
ice.ConnectionState.
Resolves #422
backkem added a commit that referenced this issue Feb 20, 2019
@backkem
API: Avoid exposing pkg/ice
f9518d9 
OnICEConnectionStateChange now return a ICEConnectionState instead of
ice.ConnectionState.
Resolves #422
backkem added a commit that referenced this issue Feb 20, 2019
@backkem
API: Avoid exposing pkg/ice
bf422e0 
OnICEConnectionStateChange now return a ICEConnectionState instead of
ice.ConnectionState.
Resolves #422
@backkem backkem removed the review label Feb 20, 2019
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@backkem
API: Avoid exposing pkg/ice
9e69be5 
OnICEConnectionStateChange now return a ICEConnectionState instead of
ice.ConnectionState.
Resolves pion#422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@backkem backkem

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@backkem