LLMAssistantAggregator: preserve non-ASCII characters in JSON output#3536
Merged
markbackman merged 1 commit intopipecat-ai:mainfrom Jan 26, 2026
Merged
LLMAssistantAggregator: preserve non-ASCII characters in JSON output#3536markbackman merged 1 commit intopipecat-ai:mainfrom
markbackman merged 1 commit intopipecat-ai:mainfrom
Conversation
Add ensure_ascii=False to json.dumps() calls for tool call arguments and function call results to prevent unnecessary unicode escaping.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where non-ASCII characters (e.g., Japanese, Chinese, etc.) were being unnecessarily escaped to Unicode sequences in LLM context, making it difficult for LLMs to understand conversations in non-English languages. The fix adds ensure_ascii=False parameter to json.dumps() calls to preserve the original character encoding.
Changes:
- Added
ensure_ascii=Falsetojson.dumps()for function call arguments serialization - Added
ensure_ascii=Falsetojson.dumps()for function call result serialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ensure_ascii=False to json.dumps() calls for tool call arguments and function call results to prevent unnecessary unicode escaping.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
solves #3535