Merged
Conversation
Codecov Report❌ Patch coverage is
... and 86 files with indirect coverage changes 🚀 New features to boost your workflow:
|
steckes
approved these changes
Feb 9, 2026
Fl1tzi
reviewed
Feb 9, 2026
…model loading, and processor behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AICFilterinstances via a singletonAICModelManagerinaic_filter.py. Multiple filters using the samemodel pathor (model_id,model_download_dir) share one loadedModeland avoid duplicate loads.acquire()instart()and releases it instop(). When the last reference is dropped, the model is evicted from the cache._get_cache_key(); reference updates use_increment_reference()and_store_new_reference()so logic is centralized and model is never optional where it is used.Testing
uv run pytest tests/test_aic_filter.py tests/test_aic_vad.py -v— all 28 tests pass, including:test_model_manager_reference_count: ref count increments on get_model, decrements on release, model evicted at 0.test_model_manager_concurrent_load_deduplication: concurrent get_model calls for the same key trigger a singleModel.from_fileand all callers receive the same model.No breaking changes: AICFilter’s public API (constructor and start/stop) is unchanged.