Emit RTVI events for user mute/unmute#3687
Merged
markbackman merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
... and 32 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ed29284 to
a546ce9
Compare
aconchillo
reviewed
Feb 9, 2026
| # Emit mute state change events | ||
| if self._user_is_muted: | ||
| await self._call_event_handler("on_user_mute_started") | ||
| await self.push_frame(UserMuteStartedFrame()) |
Contributor
There was a problem hiding this comment.
We should broadcast since this is signalling everyone. Same below.
Add UserMuteStartedFrame/UserMuteStoppedFrame and corresponding RTVI messages so clients can observe when mute strategies activate/deactivate.
a546ce9 to
00ec6c7
Compare
aconchillo
approved these changes
Feb 9, 2026
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserMuteStartedFrame/UserMuteStoppedFramesystem frames to bridge mute strategy state changes into the frame pipelineLLMUserAggregatornow pushes these frames alongside the existingon_user_mute_started/on_user_mute_stoppedevent handlers, enablingRTVIObserverto observe mute transitionsRTVIUserMuteStartedMessage(user-mute-started) andRTVIUserMuteStoppedMessage(user-mute-stopped) RTVI message types so clients can react to mute state changesuser_mute_enabledparam toRTVIObserverParams(defaults toTrue) for controlling emissionTesting