Make UserIdleController always-on with dynamic timeout updates#3748
Merged
aconchillo merged 1 commit intomainfrom Feb 19, 2026
Merged
Make UserIdleController always-on with dynamic timeout updates#3748aconchillo merged 1 commit intomainfrom
aconchillo merged 1 commit intomainfrom
Conversation
markbackman
added a commit
that referenced
this pull request
Feb 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Always create UserIdleController (timeout=0 means disabled), removing all Optional guards. Add UserIdleTimeoutUpdateFrame to allow changing the idle timeout at runtime.
markbackman
force-pushed
the
mb/user-idle-configurable
branch
from
c722caa to
5077656
Compare
markbackman
requested review from
aconchillo,
filipi87 and
kompfner
and removed request for
kompfner
aconchillo
approved these changes
Feb 19, 2026
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In thinking about the issue filed in #3742, I realized that there are likely cases where you want to enable and disable the UserIdleController conditionally. Or, change the response time. I'm surprised we haven't had this request before, but it will make the UserIdleController more flexible to include in application code.
Summary
UserIdleControllerwithtimeout=0(disabled) by default, removing allOptionaltype annotations andif self._user_idle_controller:guards fromUserTurnProcessorandLLMUserAggregatorUserIdleTimeoutUpdateFrameto allow enabling/disabling idle detection at runtime by updating the timeout dynamicallyTest plan
uv run pytest tests/test_user_idle_controller.py— all 12 tests pass (9 existing + 3 new)uv run ruff check— no lint issues🤖 Generated with Claude Code