Skip to content

Align DeepgramSageMakerSTTService finalize pattern with DeepgramSTTService#3784

Merged
markbackman merged 2 commits intomainfrom
mb/stt-sagemaker-finalize
Feb 20, 2026
Merged

Align DeepgramSageMakerSTTService finalize pattern with DeepgramSTTService#3784
markbackman merged 2 commits intomainfrom
mb/stt-sagemaker-finalize

Conversation

@markbackman
Copy link
Copy Markdown
Contributor

@markbackman markbackman commented Feb 20, 2026

Summary

  • Align DeepgramSageMakerSTTService transcription and finalize handling with the patterns used in DeepgramSTTService
  • Add request_finalize() / confirm_finalize() tracking for proper finalize lifecycle
  • Use is_final (not is_final and speech_final) as the condition for final transcriptions, matching the regular Deepgram service

Test plan

  • Verify final transcriptions are correctly detected with is_final check
  • Verify request_finalize() is called before sending the Finalize message
  • Verify confirm_finalize() is called when from_finalize is present in the response

🤖 Generated with Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pipecat/services/deepgram/stt_sagemaker.py 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/pipecat/services/deepgram/stt_sagemaker.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@filipi87 filipi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markbackman markbackman merged commit 0a3e212 into main Feb 20, 2026
6 checks passed
@markbackman markbackman deleted the mb/stt-sagemaker-finalize branch February 20, 2026 14:26
blainekasten pushed a commit to blainekasten/pipecat that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants