Add Krisp API key support and debug logging#3809
Merged
markbackman merged 3 commits intomainfrom Feb 25, 2026
Merged
Conversation
markbackman
added a commit
that referenced
this pull request
Feb 24, 2026
markbackman
force-pushed
the
mb/krisp-viva-result
branch
2 times, most recently
from
84e671a to
aeca6de
Compare
…mple Move speech detection tracking outside the per-frame loop in append_audio since is_speech applies to the whole buffer. Add debug log in analyze_end_of_turn to show state and probability at decision time. Update the Krisp VIVA example to use Cartesia TTS and turn analyzer strategy.
markbackman
force-pushed
the
mb/krisp-viva-result
branch
from
aeca6de to
65f563a
Compare
markbackman
commented
Feb 24, 2026
| ("07n-interruptible-google.py", EVAL_SIMPLE_MATH), | ||
| ("07n-interruptible-google-http.py", EVAL_SIMPLE_MATH), | ||
| ("07o-interruptible-assemblyai.py", EVAL_SIMPLE_MATH), | ||
| ("07p-interruptible-krisp-viva.py", EVAL_SIMPLE_MATH), |
Contributor
Author
There was a problem hiding this comment.
@aconchillo I can provide the Krisp SDK and model for running release evals.
markbackman
changed the title
markbackman
force-pushed
the
mb/krisp-viva-result
branch
from
69c167e to
3bb9b07
Compare
markbackman
requested review from
aconchillo and
filipi87
and removed request for
aconchillo and
filipi87
markbackman
commented
Feb 24, 2026
|
|
||
| # Extract metrics from the nested structure | ||
| metrics = result.get("metrics", {}) | ||
| inference_time = metrics.get("inference_time", 0) |
Contributor
Author
There was a problem hiding this comment.
These fields weren't populated, so removing them along with SmartTurnMetricsData.
markbackman
force-pushed
the
mb/krisp-viva-result
branch
2 times, most recently
from
a0804c2 to
10ce2d8
Compare
filipi87
reviewed
Feb 25, 2026
Comment on lines
+55
to
+56
| api_key: Krisp SDK API key. If empty, falls back to | ||
| the KRISP_API_KEY environment variable. |
Contributor
There was a problem hiding this comment.
@markbackman, is this something new? As far as I remember, we never needed an API key for Krisp before. Is it required now?
If it is required, we should probably update our docs as well:
filipi87
reviewed
Feb 25, 2026
| key = api_key or os.environ.get("KRISP_API_KEY", "") | ||
| try: | ||
| # New SDK signature (requires license key) | ||
| krisp_audio.globalInit( |
Contributor
There was a problem hiding this comment.
Even in Krisp’s own documentation, I don’t see an API key being required:
Contributor
Author
There was a problem hiding this comment.
I know, this isn't well documented, but it is required. You can find it in the SDK ref docs when you download the SDK. The Krisp team confirmed version 1.6.1 and newer require it.
filipi87
reviewed
Feb 25, 2026
| KRISP_MODEL_PATH=... | ||
|
|
||
| # Krisp Viva | ||
| KRISP_API_KEY=... |
Contributor
There was a problem hiding this comment.
Should we call it KRISP_VIVA_API_KEY to match the other environment variables?
Contributor
Author
There was a problem hiding this comment.
Good idea. Yes. I'll do that now.
filipi87
approved these changes
Feb 25, 2026
Contributor
filipi87
left a comment
filipi87
left a comment
There was a problem hiding this comment.
Thanks for confirming with Krisp. LGTM!
The Krisp VIVA SDK v1.8.0 requires a license key in globalInit(). Add api_key parameter to KrispVivaSDKManager, KrispVivaTurn, and KrispVivaFilter with fallback to KRISP_API_KEY env var. Maintain backwards compatibility with older SDK versions by catching TypeError and falling back to the old 3-arg signature.
Introduce a generic TurnMetricsData class for turn detection metrics, replacing the service-specific SmartTurnMetricsData (now deprecated). Add end-to-end processing time measurement to KrispVivaTurn, tracking the interval from VAD speech-to-silence transition to model threshold crossing. Consume metrics in the strategy _handle_input_audio path so they are pushed immediately when fresh.
markbackman
force-pushed
the
mb/krisp-viva-result
branch
from
10ce2d8 to
0ca8c85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The motivation for this PR is to provide transparency to the metrics data for
KrispVivaTurn. I took the opportunity to also remove dead code fields in theSmartTurnMetricsDataand created a genericTurnMetricsDataclass.While working on that, I found that the new Krisp SDK requires an API key, so I added support for that too, in 3bb9b07.
Summary
TurnMetricsDataas a generic metrics class for turn detection, replacing the service-specificSmartTurnMetricsData.KrispVivaTurnnow emitsTurnMetricsDatawithe2e_processing_time_msmeasuring the interval from VAD speech-to-silence transition to model threshold crossing.BaseSmartTurnnow emitsTurnMetricsDatainstead ofSmartTurnMetricsData. DeprecatedSmartTurnMetricsData(still available as a subclass for backwards compatibility).MetricsLogObservernormalizes deprecatedSmartTurnMetricsDataininclude_metricsfilters and logs all turn metrics via a unified_log_turnhandler._handle_input_audiopath whenappend_audioreturns COMPLETE, so they are pushed immediately while fresh.api_keyparameter toKrispVivaSDKManager,KrispVivaTurn, andKrispVivaFilterfor Krisp SDK v1.8.0 licensing. Falls back toKRISP_VIVA_API_KEYenvironment variable.07p,38b) to useTurnMetricsDataandMetricsLogObserver.Testing
07p-interruptible-krisp-viva.pywithKRISP_VIVA_API_KEYset and verify turn metrics are logged with e2e processing time38b-smart-turn-local.pyand verifyTurnMetricsDatametrics appear in logsinclude_metrics={SmartTurnMetricsData}still works (with deprecation warning)