Add direction parameter to PipelineTask.queue_frame() and queue_frames()#3883
Merged
aconchillo merged 2 commits intomainfrom Mar 1, 2026
Merged
Add direction parameter to PipelineTask.queue_frame() and queue_frames()#3883aconchillo merged 2 commits intomainfrom
aconchillo merged 2 commits intomainfrom
Conversation
aconchillo
added a commit
that referenced
this pull request
Mar 1, 2026
aconchillo
added a commit
that referenced
this pull request
Mar 1, 2026
aconchillo
force-pushed
the
aleix/queue-frame-direction
branch
from
300b2d5 to
1f7bf8e
Compare
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
…eue_frames() Allow pushing frames upstream through the pipeline by passing FrameDirection.UPSTREAM. Downstream frames use the existing push queue, while upstream frames are pushed directly from the pipeline sink.
aconchillo
force-pushed
the
aleix/queue-frame-direction
branch
from
1f7bf8e to
94a59de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directionparameter toPipelineTask.queue_frame()andPipelineTask.queue_frames(), defaulting toFrameDirection.DOWNSTREAM(existing behavior)FrameDirection.UPSTREAM, frames are pushed directly from the pipeline sink (end of the pipeline) instead of going through the downstream push queueself._sinkonPipelineTaskto support upstream frame injectionTesting
uv run pytest tests/test_pipeline.py::TestPipelineTask::test_task_queue_frame_upstreamuv run pytest tests/test_pipeline.py::TestPipelineTask::test_task_queue_frames_upstream🤖 Generated with Claude Code